Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: unable to edit launch options after toggling mods #206

Open
LittlePlanlessFool opened this issue Aug 4, 2023 · 5 comments
Open

bug: unable to edit launch options after toggling mods #206

LittlePlanlessFool opened this issue Aug 4, 2023 · 5 comments
Labels
bug Something isn't working low priority Issues that shouldn't be closed but also aren't critical not reproducible Bug/Problem that can't be reproduced

Comments

@LittlePlanlessFool
Copy link

Describe the bug
After toggling all mods, launch options can only be highlighted and deleted, not entered

To Reproduce
Steps to reproduce the behavior:

  1. Go to Mods
  2. Click on "Toggle All"
  3. Click on either "Cancel" or "Ok"
  4. Open settings
  5. Click on "Launch options" text field

Expected behavior
a cursor should appear so text can be entered

Version:
Release 1.8.1

Additional Info
restarting the app fixes this

@0neGal 0neGal added the bug Something isn't working label Aug 6, 2023
@LittlePlanlessFool
Copy link
Author

LittlePlanlessFool commented Aug 7, 2023

Viper.2023-08-07.12-05-37_Trim.mp4

not visible is the dialogue to confirm toggling the mods
focusing another program also fixes this
the same bug also affects the dialogue box "Retain files on update"

@0neGal
Copy link
Owner

0neGal commented Aug 7, 2023

I cant seem to reproduce this, at least on Linux, this may be a problem with Electron/Chromium as a whole, I'll possibly end up yanking out my very old and dusty install of Windows to confirm this, unless somebody else can confirm it being broken on Windows but not on Linux.

Though it may be possibly to work out a janky fix to this through .blur() and then .focus() on the input when the window loses and or regains focus?

Once again, further testing is needed here...

@0neGal 0neGal added low priority Issues that shouldn't be closed but also aren't critical not reproducible Bug/Problem that can't be reproduced labels Aug 7, 2023
@0neGal
Copy link
Owner

0neGal commented Sep 14, 2023

Viper recently updated from Electron v22.0.0 to v22.3.21, and it may have fixed this, can you attempt to reproduce this bug in the latest version of Viper (v1.8.5)?

@LittlePlanlessFool
Copy link
Author

Behaviour still persist in v1.8.5

@0neGal
Copy link
Owner

0neGal commented Sep 17, 2023

I had some hope, but thanks for testing anyway.

I'll consider updating to the latest Electron version at some point, albeit this is a low-priority bug so I won't invest time in that right now, as I'd have to test for any breaking changes between major Electron versions...

If anybody else can reproduce this reliably, especially on platforms other than Windows, then that'd be very helpful, I'll have a look at reproducing it myself whenever I get the time and ability to spin up a Windows installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Issues that shouldn't be closed but also aren't critical not reproducible Bug/Problem that can't be reproduced
Projects
None yet
Development

No branches or pull requests

2 participants