Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronizer: Add a debug feature to call Executor with NoCounters flag to true #3693

Open
joanestebanr opened this issue Jun 6, 2024 · 0 comments
Assignees
Milestone

Comments

@joanestebanr
Copy link
Contributor

joanestebanr commented Jun 6, 2024

Rationale

For a development propuses we need to avoid Counters checks on executor.
This is a feature forbidden in production environment for that reason the activation is going to be a bit complicated:

  • Activate in the configuration file:
[Synchronizer]
(...)
ExecuteBatchNoCountersFlag = false
  • Also need a enviornment variable set to allow to use this value:
export ALLOW_EXECUTE_BATCH_NO_COUNTERS_FLAG=1
  • To prevent to activate this by error, also a invocation parameter is required to allow to set this value:
/app/zkevm-node run --allow-execute-batch-no-counters-flag

So basically you need the 3 params to be able to enable this feature

Another defensive mechanims is:

  • If the chainID is mainnet prevent to change this flag event then rest of conditions are fulfilled

Implementation

Do you have ideas regarding the implementation of this feature?
Are you willing to implement this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant