Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to Merge New Features into the tiny-cuda-nn Repository #1

Open
gerwang opened this issue Aug 27, 2023 · 1 comment
Open

Comments

@gerwang
Copy link

gerwang commented Aug 27, 2023

Hello @19reborn,

Thanks for your awesome project! I wanted to discuss the possibility of merging the features you've developed for the NeuS2_TCNN repository into the tiny-cuda-nn repository. The accompanying paper suggests that these features could complement the goals of tiny-cuda-nn and enhance its capabilities.

Considering the well-established testing period and ongoing maintenance of tiny-cuda-nn, merging your features could lead to a more robust and future-proof codebase. This collaboration would avoid duplication of efforts and ensure that your features stay compatible with the latest updates.

I'd appreciate your thoughts on this proposal and whether it aligns with your vision for the projects. Let's discuss the potential benefits and the path forward. Thank you!

@19reborn 19reborn reopened this Aug 27, 2023
@19reborn
Copy link
Owner

Hi @gerwang, thanks for your consideration and great proposal. It would be really nice if NeuS2_TCNN could be integrated into the tiny-cuda-nn repository. However, I have some concerns:

  1. Our implementation of the backward_backward_input is tailored for the Relu-based MLPs only.
  2. Some codes need to be refined before integration.
  3. We may still need the NeuS2_TCNN for NeuS2 repository since we have modified some APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants