Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error of TADbit clean #389

Open
iagomaceda opened this issue Aug 30, 2023 · 3 comments
Open

Error of TADbit clean #389

iagomaceda opened this issue Aug 30, 2023 · 3 comments

Comments

@iagomaceda
Copy link
Contributor

Hi,

If the user merges 3 or more replicates into a single one using tadbit merge and wants to clean the final folder (to only have the bam file that results from the last merge), the original folders will be deleted.

Example of the code used:

tadbit merge --workdir merge_dir --workdir1 rep1_dir --workdir2 rep2_dir --cpus 16 --skip_comparison [jobid 1]

tadbit merge --workdir merge_dir --workdir1 merge_dir --workdir2 rep3_dir --cpus 16 --skip_comparison [jobid 2]

tadbit clean -w merge_dir -j 1 --delete

When running the tadbit clean command rep1_dir and rep2_dir will be deleted.

TADbit version: 1.0.1 (installed via conda)

Thanks

@fransua
Copy link
Member

fransua commented Aug 31, 2023

Hola Iago,
can you try the same creating a new workdir for each merge

@iagomaceda
Copy link
Contributor Author

Hi,

Thanks for the rapid response, fransua.

So the code would be something like this?

tadbit merge --workdir merge_dir_1 --workdir1 rep1_dir --workdir2 rep2_dir --cpus 16 --skip_comparison

tadbit merge --workdir merge_dir_2 --workdir1 merge_dir --workdir2 rep3_dir --cpus 16 --skip_comparison

rm -rf merge_dir_1

Thanks

@fransua
Copy link
Member

fransua commented Sep 1, 2023

yes, this should work.
(don;t delete before checking... and perhaps you should have a look at the comparisons. To make them faster set a low resolution, like 500k or so)

"important bug"... 🤬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants