New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing validation for Responses #6050

Open

njohner opened this issue Nov 13, 2019 · 0 comments

Labels

Contributor

njohner commented Nov 13, 2019

opengever.base.response.Responses are not getting validated, neither upon creation in code, nor when generated over API. Moreover note that:

in the __init__ we used to set text = '', but text is a schema.Text field, and should therefore be unicode. This was fixed in Use BaseResponse for proposal history to add API support #6039
in the __init__ we default text to an empty string, but in the schema definition we used to have (before Use BaseResponse for proposal history to add API support #6039) the defaulted to None

The text was updated successfully, but these errors were encountered:

njohner mentioned this issue

Use BaseResponse for proposal history to add API support #6039

Merged

3 tasks

phgross added the validate label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment