Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::shared_ptr to std::unique_ptr in WrapTFile, AvgBuffer #36

Open
neiser opened this issue Mar 11, 2017 · 0 comments
Open

Replace std::shared_ptr to std::unique_ptr in WrapTFile, AvgBuffer #36

neiser opened this issue Mar 11, 2017 · 0 comments

Comments

@neiser
Copy link
Contributor

neiser commented Mar 11, 2017 •
edited
Loading

Do not force the user of such utilities/wrappers to shared ownership, but provide only unique_ptr. Can still be converted to shared_ptr if required by the user. But since ROOT with its own idea about object ownership is involved, it's hard to tell if such an interface change has no side effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neiser