Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise all uses of metadata to see if named metadata should be used #2453

Open
addisoncrump opened this issue Jul 26, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@addisoncrump
Copy link
Collaborator

We use normal metadata in several places where named metadata should be used (e.g., you cannot have multiple MOpt instances with a single state). We should revise everywhere that we use metadata to see if named metadata should be used instead.

@addisoncrump addisoncrump added the bug Something isn't working label Jul 26, 2024
@domenukk
Copy link
Member

One issue is that named has extra overhead over non-named, right? Since it's two hash lookups instead of one

@addisoncrump
Copy link
Collaborator Author

Perhaps so, but as it stands it is outright wrong. We'll need to document compatibilities if nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants