Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion regarding MINIMUM_SPANNING_TREE #12

Open
mou23 opened this issue Jan 10, 2020 · 6 comments
Open

Confusion regarding MINIMUM_SPANNING_TREE #12

mou23 opened this issue Jan 10, 2020 · 6 comments

Comments

@mou23
Copy link

mou23 commented Jan 10, 2020

Both of the buggy BREADTH_FIRST_SEARCH and DEPTH_FIRST_SEARCH.java use Node.java from buggy_java_programs package. Why does MINIMUM_SPANNING_TREE use java_programs.Node?

Again, the MINIMUM_SPANNING_TREE_TEST.java imports the correct version of the program. Shouldn't it be executed on the buggy version?

Thanks in advance.

@SophieHYe
Copy link

Hi @mou23,

Thanks very much for your comment and for pointing the mistakes and they have been updated here.
As java_programs.Node and buggy_java_programs.Node has the same content, so the logic wouldn't be impacted! Thanks for raising the issue!

@mou23
Copy link
Author

mou23 commented Jan 10, 2020

Yea. But what about MINIMUM_SPANNING_TREE_TEST.java? It imports the correct version of MINIMUM_SPANNING_TREE.java..Shouldn't it be the buggy one?

@SophieHYe
Copy link

Sorry I don't understand your question very well. As you reported before, MINIMUM_SPANNING_TREE.java was incorrectly imported the Node.java and WeightedEdge.java from java_programs instead of buggy_programs. But these two classes are not the 40 buggy algorithmic programs. The correct version of the buggy version of Node.java and WeightedEdge.java is the same.

@mou23
Copy link
Author

mou23 commented Jan 10, 2020

Actually I am sorry. I typed the filename wrong in the second paragraph. It should be MINIMUM_SPANNING_TREE_TEST.java

I had two confusion. First one regarding MINIMUM_SPANNING_TREE.java, which you have already resolved. Another one about MINIMUM_SPANNING_TREE_TEST.java. It imports the correct version of MINIMUM_SPANNING_TREE.java. Shouldn't it be the faulty one?

@SophieHYe
Copy link

Hi Moumita,
I see your point and thanks for pointing. You are right! That's a bug, I will fix it soon.

@mou23
Copy link
Author

mou23 commented Jan 11, 2020

Thank you so much 😃 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants