Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternatives files have inconsistent formatting #846

Open
jpn-- opened this issue Apr 4, 2024 · 1 comment
Open

alternatives files have inconsistent formatting #846

jpn-- opened this issue Apr 4, 2024 · 1 comment
Labels
Chore Changes don't modify src or test files

Comments

@jpn--
Copy link
Member

jpn-- commented Apr 4, 2024

     # FIXME setting index as "Alt" causes crash in estimation mode...
     # happens in joint_tour_frequency_composition too!
     # alts = simulate.read_model_alts(state, model_settings.ALTS, set_index="Alt")
     alts = simulate.read_model_alts(state, model_settings.ALTS, set_index=None)
     alts.index = alts["Alt"].values

I noticed all other models' alternatives files have the alternative column named and hardcoded in source code as alt, but for school escorting, it is Alt. It's probably better to keep the column name consistent as alt, even though we are not addressing the "hardcoded" part at this moment.

Originally posted by @i-am-sijia in #777 (comment)

I think we should treat this issue separately from this PR. If we change it here, it will have implications for people who are already using the model (i.e. they would have to change their alternatives file). This is larger than simply changing it here as the Alt name is coded in a couple of places in this file and I would like to keep this PR focused on the BayDAG contributions. Thus, I think we should track it in a separate and stand-alone issue. Thoughts?

Originally posted by @dhensle in #777 (comment)

@i-am-sijia
Copy link
Contributor

@jpn-- Would it be a good idea to have an AlternativeSettings class, that checks alt file?

@dhensle dhensle added the Chore Changes don't modify src or test files label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes don't modify src or test files
Projects
Status: No status
Development

No branches or pull requests

3 participants