Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $network support to FireFox #2940

Open
Alex-302 opened this issue Sep 10, 2024 · 2 comments
Open

Add $network support to FireFox #2940

Alex-302 opened this issue Sep 10, 2024 · 2 comments

Comments

@Alex-302
Copy link
Member

Issue Details

uBlockOrigin/uBlock-issues#2792
gorhill/uBlock@c6dedd2

Perhaps the name of the modifier should be changed, as the capabilities in CoreLibs and in Firefox are different.

AdGuard syntax of CoreLibs: https://adguard.com/kb/ru/general/ad-filtering/create-own-filters/#network-modifier

Proposed solution

Add $network support to FireFox

Alternative solution

No response

@DandelionSprout
Copy link
Member

DandelionSprout commented Sep 10, 2024

I'd normally have proposed to stick to calling it $network instead of $ipaddress, but from my very earliest impressions of the latter, it seems to have more possible parameters that can be added ($script was listed as an example, and I'm betting big that $all is also supported).

@DandelionSprout
Copy link
Member

DandelionSprout commented Sep 10, 2024

Update: At the time of writing, it appears $ipaddress cannot block sites outright, only the various scripts/images/frames/similar on those sites. So it falls somewhat short of what $network does for non-"Browser Extension" AdGuard versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants