Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty tracer config header sent if no config selected #36

Open
chetanmeh opened this issue Oct 10, 2016 · 3 comments
Open

Empty tracer config header sent if no config selected #36

chetanmeh opened this issue Oct 10, 2016 · 3 comments

Comments

@chetanmeh
Copy link
Collaborator

There is a panel to select/enable ad hoc loggers. If none of the logger is selected then an empty tracer config header is sent which causes request to fail on server side. This has been handled better with SLING-6118 however it would be good that plugin does not send any header if no logger is selected

@davidjgonzalez
Copy link
Contributor

@chetanmeh I changed it to send Sling-Tracer-Config:sling-tracer-configs-not-set;caller=true if no tracer sets are specified. I did this so we can still send ;caller=true which is now helpful (with the new LoggerNames panel) to pick a tracerSet to tracer on; else its a chicken-and-the-egg situation.

This seems to work fine unless there is a better syntax?

image

@chetanmeh
Copy link
Collaborator Author

Note that the logger names are collected by default and does not depend on passing caller param. That param is only required if you are interested in caller stacks

@davidjgonzalez
Copy link
Contributor

Ah; I thought it odd since the caller is attached to each tracer set.

Let me check again - I had the issue where loggernames were empty when my sling-tracer-config header was not present, thus the dummy value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants