From 22547ccda15b07d0ad9ce55689ad1cad65dfee89 Mon Sep 17 00:00:00 2001 From: Max Cobb Date: Fri, 8 Oct 2021 10:04:37 +0100 Subject: [PATCH 1/3] extension helpers public --- Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift b/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift index ce2d86b4..85f6b656 100644 --- a/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift +++ b/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift @@ -7,7 +7,7 @@ import AgoraRtcKit -extension AgoraVideoViewer { +public extension AgoraVideoViewer { /// Enable/Disable extension. No different from the Agora SDK call. /// - Parameters: /// - vendor: name for provider, e.g. agora.builtin. From c9a586106c75848b1b13000d2b6ff849fd5f8e1c Mon Sep 17 00:00:00 2001 From: Max Cobb Date: Fri, 8 Oct 2021 10:26:17 +0100 Subject: [PATCH 2/3] bumped version numbers --- AgoraUIKit_iOS.podspec | 2 +- Sources/Agora-UIKit/AgoraUIKit.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/AgoraUIKit_iOS.podspec b/AgoraUIKit_iOS.podspec index 12b723d8..fd38688a 100644 --- a/AgoraUIKit_iOS.podspec +++ b/AgoraUIKit_iOS.podspec @@ -8,7 +8,7 @@ Pod::Spec.new do |s| s.name = 'AgoraUIKit_iOS' - s.version = '4.0.0-preview.5' + s.version = '4.0.0-preview.6' s.summary = 'Agora video session UIKit template.' s.description = <<-DESC diff --git a/Sources/Agora-UIKit/AgoraUIKit.swift b/Sources/Agora-UIKit/AgoraUIKit.swift index 756d5a68..20873bb7 100644 --- a/Sources/Agora-UIKit/AgoraUIKit.swift +++ b/Sources/Agora-UIKit/AgoraUIKit.swift @@ -22,7 +22,7 @@ public struct AgoraUIKit: Codable { /// Framework type of UIKit. "native", "flutter", "reactnative" fileprivate(set) var framework: String /// Version of UIKit being used - static let version = "4.0.0-preview.5" + static let version = "4.0.0-preview.6" /// Framework type of UIKit. "native", "flutter", "reactnative" static let framework = "native" #if os(iOS) From 90fb9fea05924bd259495fa85fb020c66064a2c1 Mon Sep 17 00:00:00 2001 From: Max Cobb Date: Fri, 8 Oct 2021 10:27:49 +0100 Subject: [PATCH 3/3] set extension methods to open instead of public --- .../AgoraVideoViewer+AgoraExtensions.swift | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift b/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift index 85f6b656..e44b0ef7 100644 --- a/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift +++ b/Sources/Agora-UIKit/AgoraVideoViewer+AgoraExtensions.swift @@ -7,7 +7,7 @@ import AgoraRtcKit -public extension AgoraVideoViewer { +extension AgoraVideoViewer { /// Enable/Disable extension. No different from the Agora SDK call. /// - Parameters: /// - vendor: name for provider, e.g. agora.builtin. @@ -15,7 +15,7 @@ public extension AgoraVideoViewer { /// - enabled: enable or disable. - true: enable. - false: disable. /// - Returns: `0`: Success. `<0`: Failure. @discardableResult - func enableExtension(withVendor vendor: String, extension extString: String, enabled: Bool) -> Int32 { + open func enableExtension(withVendor vendor: String, extension extString: String, enabled: Bool) -> Int32 { return self.agkit.enableExtension(withVendor: vendor, extension: extString, enabled: enabled) } @@ -27,7 +27,7 @@ public extension AgoraVideoViewer { /// - value: string value to set. /// - Returns: `0` = Success. `<0` = Failure. @discardableResult - func setExtensionProperty( + open func setExtensionProperty( _ vendor: String, extension extString: String, key: String, value: String ) -> Int32 { return self.agkit.setExtensionPropertyWithVendor( @@ -44,7 +44,7 @@ public extension AgoraVideoViewer { /// - codable: value to set for the property, must be encodable to a JSON string. /// - Returns: `0` = Success. `<0` = Failure. @discardableResult - func setExtensionProperty( + open func setExtensionProperty( _ vendor: String, extension extString: String, key: String, codable: T ) -> Int32? where T: Encodable { guard let encodedData = try? JSONEncoder().encode(codable), @@ -66,7 +66,7 @@ public extension AgoraVideoViewer { /// - strValue: string value to set. /// - Returns: `0` = Success. `<0` = Failure. @discardableResult - func setExtensionProperty( + open func setExtensionProperty( _ vendor: String, extension extString: String, key: String, strValue: String ) -> Int32 { return self.agkit.setExtensionPropertyWithVendor( @@ -83,7 +83,7 @@ public extension AgoraVideoViewer { /// - value: Boolean value to set. /// - Returns: `0` = Success. `<0` = Failure. @discardableResult - func setExtensionProperty( + open func setExtensionProperty( _ vendor: String, extension extString: String, key: String, value: Bool ) -> Int32 { return self.agkit.setExtensionPropertyWithVendor(