Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up code #18

Open
4 of 7 tasks
AlexzPurewoko opened this issue Apr 23, 2021 · 0 comments
Open
4 of 7 tasks

Cleaning up code #18

AlexzPurewoko opened this issue Apr 23, 2021 · 0 comments
Assignees
@AlexzPurewoko
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@AlexzPurewoko
Copy link
Owner

AlexzPurewoko commented Apr 23, 2021 •
edited
Loading

This will fix :

  • Remapping module :data (with nullability to prevent crash)
  • Find and fix code that not accept clean code
  • Find and fix uncompleted tests (local testing and android-host testing)
  • Cleaning up code (such deleting all unused, and delete deprecated methods)
  • Test and Fix issue

Improvization (if possible) :

  • Form a new style of local test with kotest
  • Test and fix again
@AlexzPurewoko AlexzPurewoko self-assigned this Apr 25, 2021
@AlexzPurewoko AlexzPurewoko added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 25, 2021
AlexzPurewoko added a commit that referenced this issue May 2, 2021
@AlexzPurewoko
Merge branch 'main' into #18-cleaning-up-code
50bcca8 
# Conflicts:
#	library/data/src/main/java/id/apwdevs/app/data/mediator/PopularMovieRemoteMediator.kt
#	library/data/src/main/java/id/apwdevs/app/data/source/local/entity/items/MovieEntity.kt
AlexzPurewoko added a commit that referenced this issue May 4, 2021
@AlexzPurewoko
Merge pull request #29 from AlexzPurewoko/#18-cleaning-up-code
9415875 
#18 cleaning up code
AlexzPurewoko added a commit that referenced this issue May 4, 2021
@AlexzPurewoko
Merge pull request #29 from AlexzPurewoko/#18-cleaning-up-code
981a2a2 
#18 cleaning up code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexzPurewoko AlexzPurewoko

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexzPurewoko