Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Usertests - Big Files #11

Open
waltage opened this issue Sep 24, 2022 · 4 comments
Open

Failing Usertests - Big Files #11

waltage opened this issue Sep 24, 2022 · 4 comments

Comments

@waltage
Copy link

waltage commented Sep 24, 2022

for (i = 0; i < MAXFILE; i++) {

There's a bug in this printf statement that causes a balloc crash if the test was going to fail (could not write the full 140 blocks)

Additionally, this test in general needs to change to account for current User space disk space usage vs. the current setting of the Filesystem size in param.h (if students have more than a few binaries in their root, and/or the sum total of their user + kernel binaries is greater than FSSIZE - 140 * BSIZE, the "large file" test will fail inherently)

@nickelpro
Copy link
Collaborator

Is it common for students to have lots of non-default user programs and significantly inflated kernel binaries for any given assignment? Just trying to sus-out the user story here. On the undergrad side students are working on a distinct fork of the template for each assignment, so we never run into the problem where such an accounting would be valuable.

@nickelpro
Copy link
Collaborator

Or is this bug simply saying that the user test crashes instead of fails? Ya spo'se we should fix that

@waltage
Copy link
Author

waltage commented Sep 24, 2022

I'm trying to get one of our TAs to work on it

@waltage
Copy link
Author

waltage commented Sep 24, 2022

Is it common for students to have lots of non-default user programs and significantly inflated kernel binaries for any given assignment? Just trying to sus-out the user story here. On the undergrad side students are working on a distinct fork of the template for each assignment, so we never run into the problem where such an accounting would be valuable.

I have a lot of students that make multiple intermediate copies of user binaries with different behaviors/tests. We typically model assignments after an existing user binary, so copy-paste is a common first step. We don't recommend that, but what can you do

The current assignment they're working on required 3 programs for us, too, so when they had even one other up it would fail that test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants