Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working and comments #1

Open
BaseMax opened this issue Feb 20, 2022 · 15 comments
Open

Working and comments #1

BaseMax opened this issue Feb 20, 2022 · 15 comments

Comments

@BaseMax
Copy link
Member

BaseMax commented Feb 20, 2022

Hi friends, this is where we will talk about details, problems, bugs and improvements.

سلام دوستان، اینجا جایی است که در مورد جزئیات، مشکلات، باگ ها و پیشرفت ها صحبت خواهیم کرد.
@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

bug:
image

add pay and add receive need to show a modal/popup
also add many more test transactions to the list
connect transaction list to reactjs variable
like todos array. but we called it transactions
change User text to WhereMoney inside toolbar
also we need to design login/register page.
name+email+pass are fine, easy to login, easy to register
also we will need forgot password page in next step.

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

image

icons are same, we need to change one of them.

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

Next feature:
show a centered message: sorry you not have any Transaction yet! message when the Transaction list is empty.
(with a centered icon at top of text; this maybe help to make page more beauty..)

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

Hey john, can you please add a bot such as vercel for development LIVE preview? @jbampton

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

What to add inside modal?

title or maybe name of sender/receiver
descirption (optional field)
amount (number, it can be float digits and required)
a checkbox to ask do you want to calculate this transaction in your monthly data? (default it checked)
and also a list of types which can showed as icon

image
image

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

image

Black border is bad
No, black 🖤 border is not good
Use gray or something like that

When you add border on hover or click event
Height of select box will change
It's not good too
Add same size border with transparent color in Norma l

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

also we need a switch to change language of panel
and change dir and lang of html tag.
<html dir="rtl" lang="fa_IR">
and
<html dir="ltr" lang="en">
also we need to load all words,text from js or json file. (in build)

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

another bug:
image

look at space between amount and description, its not equal to space between desc and name.

@BaseMax
Copy link
Member Author

BaseMax commented Feb 20, 2022

Feature:
when user click on "add pay" default value of type should be "outcome" or "income" and also for next btn...

@BaseMax
Copy link
Member Author

BaseMax commented Feb 21, 2022 

  { icon: Book, value: "book" },
  { icon: Dice, value: "Dice" },
  { icon: File, value: "File" },
  { icon: Suitcase, value: "Suitcase" },
  { icon: Taxi2, value: "Taxi2" },
  { icon: Tshirt, value: "Tshirt" },

we need to read all text from js or json files

@BaseMax
Copy link
Member Author

BaseMax commented Feb 21, 2022

Why Taxi2? do you mean Taxi?

@BaseMax
Copy link
Member Author

BaseMax commented Feb 21, 2022

we plan to support 2 languages.
<FormLabel id= change to <FormLabel id=

at src/components/modal/Modal.tsx

@BaseMax
Copy link
Member Author

BaseMax commented Feb 21, 2022

YOU need to hide body scroll when dialog/popup/modal open.

@BaseMax
Copy link
Member Author

BaseMax commented Feb 21, 2022

image

modal bottom margin is not equal to left/right margin space.

@BaseMax
Copy link
Member Author

BaseMax commented Feb 23, 2022

New feature:
Read and get all text or word from object/array it can be JS or JSON file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BaseMax