Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the Barry-Goldman quaternions spline is always closed? #2

Open
stla opened this issue Oct 25, 2021 · 1 comment
Open

Why the Barry-Goldman quaternions spline is always closed? #2

stla opened this issue Oct 25, 2021 · 1 comment

Comments

@stla
Copy link

stla commented Oct 25, 2021

Hello,

I'm currently working on implementing the Barry-Goldman quaternions spline in the R language. I follow your code. I am wondering why you set it closed. Is there a problem if we don't close the spline with this algorithm?
@mgeier
Copy link
Member

mgeier commented Oct 26, 2021

No, I don't think so.

Handling the end conditions is just a bit more complicated and I didn't need this yet, so I didn't do it (yet?).

I'm preferring the splines.quaternion.CatmullRom (via splines.quaternion.DeCasteljau), because this directly yields the angular velocity. I've implemented splines.quaternion.BarryGoldman just for comparison, and the closed one was sufficient for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgeier @stla