Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lone hit area #733

Open
shenyangshi opened this issue Jun 7, 2023 · 4 comments
Open

Lone hit area #733

shenyangshi opened this issue Jun 7, 2023 · 4 comments

Comments

@shenyangshi
Copy link
Contributor

h['area'] = (
r['data'][start:end].sum()
+ (r['baseline'] % 1) * (end - start))

If we make the lone hits area also normalized according to PMT adc_to_pe like the peaklets instead of [ADC x samples], will it cause trouble elsewhere?

@WenzDaniel
Copy link
Collaborator

We would need to check where it is called. Would there be a big benefit changing it into pe?

@shenyangshi
Copy link
Contributor Author

Thanks for the quick response @WenzDaniel! Since the gain model is a time-dependent correction, people interested in lone hits properties like area, DPE component or stability need to fetch the corrections themselves and correct run-by-run. I think it's nice if we can do this at the basement level.

@shenyangshi
Copy link
Contributor Author

Maybe @a1exndr and @PALOMA can comment on the influence on the lone hit gain correction.

@WenzDaniel
Copy link
Collaborator

We can change it if needed. But this requires some careful checks and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants