-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lone hit area #733
Comments
We would need to check where it is called. Would there be a big benefit changing it into pe? |
Thanks for the quick response @WenzDaniel! Since the gain model is a time-dependent correction, people interested in lone hits properties like area, DPE component or stability need to fetch the corrections themselves and correct run-by-run. I think it's nice if we can do this at the basement level. |
We can change it if needed. But this requires some careful checks and testing. |
strax/strax/processing/peak_building.py
Lines 482 to 484 in afaf8cf
If we make the lone hits area also normalized according to PMT adc_to_pe like the peaklets instead of [ADC x samples], will it cause trouble elsewhere?
The text was updated successfully, but these errors were encountered: