Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facing issues when using msal-browser and msal-react in chrome extension #130

Open
kiritjoshidev opened this issue Oct 21, 2024 · 1 comment

Comments

@kiritjoshidev
Copy link

kiritjoshidev commented Oct 21, 2024

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x] bug report -> please search issues before submitting
- [] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Run this sample link with updated msal-browser and msal-react packages

Any log messages given by the failure

Info - handleRedirectPromise called but there is no interaction in progress, returning null.

Expected/desired behavior

I should get authenticated even when there is no redirection

OS and Version?

Windows 11

Versions

@azure/msal-browser": "^3.26.1"
@azure/msal-react": "^2.1.1"

Mention any other details that might be useful

This happens when I return false from onRedirectNavigate in msalConfig which is suggested in this sample.


Thanks! We'll be in touch soon.

@kiritjoshidev kiritjoshidev changed the title Facing issues when using msal-broswer and msal-react in chrome extension Facing issues when using msal-browser and msal-react in chrome extension Oct 21, 2024
@kiritjoshidev
Copy link
Author

Okay, I found the issue. I did not use onRedirectNavigate in instance.loginRedirect to resolve the url and instead used it in msal config as it will be removed in the next major version of msal-browser.

So it will become a problem for extensions once next major release is out.
Can anyone comment on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant