-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LintDiff] Upgrade autorest to latest #7755
Comments
I think that's just the CLI version which I don't think would solve the issue in question(It wouldnt' be bad to update that too, however). What is failing the |
@timotheeguerin how to update the core? |
Core would either use the latest or a version configured by |
@timotheeguerin from this recent example log we can see:
Notably:
Judging based on that, the issue is with CLI or Core or hard to say? |
the cli just basically loads The original issue is complaining about missing For example having this: "x-ms-enum": { "modelAsString": false} There was some assumption that might have just been an older autorest complaining but it might be something else using an outdated json schema to validate. |
Please prioritize. the ShiftLeft pipeline started failing and it's unclear to me what I have to change/fix in order to get it unblocked |
Relevant discussion on Teams here |
LintDiff is currently using
autorest
pinned to 3.6.1:https://dev.azure.com/devdiv/DevDiv/_git/openapi-alps?path=/private/azure-swagger-validation/azureSwaggerValidation/package.json&version=GBmain&line=36&lineEnd=37&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents
It should probably be upgraded to the latest version
3.7.1
, since3.6.1
is two years old now. However, I'm not aware of any current issues using3.6.1
, so maybe it's better to not touch it unless we need to?I believe
autorest@3.6.1
should automatically use the latest version of@autorest/core
, since by defaultautorest
floats the dependency as@autorest/core@^3.2.0
:https://github.com/Azure/autorest/blob/8d137ce24e1af96444766688e7cd851767d6543c/packages/apps/autorest/src/app.ts#L42
For reference:
momentOfTruth.ts
.The text was updated successfully, but these errors were encountered: