Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed to submit even not Select the Samples to add Molecule information #315

Open
luissian opened this issue Sep 27, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@luissian
Copy link
Member

Description of the bug

When no molecule is selected to add information then in the next page that is present is almost empty
image

And when click again to submit button the follow error occur
image

Command used and terminal output

No response

Relevant files

No response

System information

No response

@luissian luissian added the bug Something isn't working label Sep 27, 2024
@luissian luissian added this to the Ready for 3.2.0 milestone Sep 27, 2024
@luissian luissian self-assigned this Sep 27, 2024
luissian added a commit to luissian/iskylims that referenced this issue Sep 27, 2024
@luissian
Copy link
Member Author

Added in java script the check that at least 1 sample must be selected and in code fix the error that allowed to check for row[check_field] != "" . The value when is not selected is False because the json coversion . It made that all samples were selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant