-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BabylonNative UWP dependencies should be converted to a single dll to decrease package file size #146
Comments
in order to support multiple react-native-windows projects referencing Microsoft.ReactNative.vcxproj, it seems like we actually need Microsoft.ReactNative.dll/winmd distributed as a precompiled binary that all consuming projects reference. Otherwise different versions of Microsoft.ReactNative.dll will be built for the npm package vs applications consuming the npm package and we will always have conflicting xbf files/compilation timestamps/hashes |
it seems like specifically we may need the following change: microsoft/react-native-windows#4540 |
Initial context
Goal:
How we can do this:
NuGet feed usage
Other knowns/Issues:
|
Right now published packages supporting windows have greatly increased the package file size (60mb -> 960mb). There are some issues with react-native-windows and multi-layer referencing that make this difficult to fix. But we should do something to get back to a smaller package size.
talking to other folks it also sounds like it is already bad practice to distribute static libs. If folks try and build BabylonReactNative.dll with a compiler/linker version that doesn't match the static libs, we will get into unsupported/undefined behavior.
The text was updated successfully, but these errors were encountered: