Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisualStudio 2022 support #358

Closed
CedricGuillemet opened this issue Mar 9, 2022 · 4 comments
Closed

VisualStudio 2022 support #358

CedricGuillemet opened this issue Mar 9, 2022 · 4 comments
Milestone

Comments

@CedricGuillemet
Copy link
Contributor

I did a quick test (unfortunate) building BRN with VS2022 and got compilation error

E:\dev\babylon\BRNDeploy064\Apps\Playground\Playground\node_modules\react-native-windows\Mso\dispatchQueue\dispatchQueue.h(728,17): error C2607: static assertion failed
       [E:\dev\babylon\BRNDeploy064\Apps\Playground\Playground\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]

I don't know if it's related to VS, Windows SDK or something else. Anyway, a test with newest VS might be a good idea.

@bghgary
Copy link
Contributor

bghgary commented Mar 9, 2022

I'm not sure this belongs in BabylonReactNative repo. We already know VS2022 doesn't work in BabylonNative repo. Not sure there is an issue on it though. (it works now)

@CedricGuillemet
Copy link
Contributor Author

CedricGuillemet commented Mar 9, 2022

Problems won't be the same because of dependencies (react native windows and other packages). It won't be as hard/ time consuming with BN.

EDIT: The problem is not the same between BN and BRN. for BN, it's a cmake/gradle problem. Here, it's a Windows SDK/CPP version issue.

@thomlucc thomlucc added the 6.0 label Sep 23, 2022
@thomlucc thomlucc added this to the 6.0 milestone Sep 23, 2022
@thomlucc thomlucc removed the 6.0 label Sep 23, 2022
@CedricGuillemet
Copy link
Contributor Author

When trying the playground build/test githubaction with VS2022, I got this error:

D:\a\BabylonReactNative-1\BabylonReactNative-1\Playground\node_modules\react-native-windows\Microsoft.ReactNative\Utils\Helpers.h(21,8): error C2187: syntax error: 'typename' was unexpected here (compiling source file Modules\LogBoxModule.cpp) [D:\a\BabylonReactNative-1\BabylonReactNative-1\Playground\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]

It's fine with VS2019

@bghgary bghgary modified the milestones: 6.0, Future Feb 9, 2023
@CedricGuillemet CedricGuillemet modified the milestones: Future, 7.0 May 26, 2023
@thomlucc thomlucc modified the milestones: 7.0, 8.0 Apr 2, 2024
@bghgary
Copy link
Contributor

bghgary commented Sep 10, 2024

Based on #656, it seems like this works already.

@bghgary bghgary closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants