Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file needs to be re-written to better handle multiple models #120

Open
JohnGiorgi opened this issue Feb 28, 2019 · 0 comments
Open
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@JohnGiorgi
Copy link
Contributor

JohnGiorgi commented Feb 28, 2019

Currently, the config.ini file, which contains settings for using Saber, is highly coupled to the Keras BiLSTM-CRF model. This needs to be fixed.

One solution would be to maintain a different config file for each of the model's Saber implements. A second solution would be to have model specific subsections in the config file, e.g.

[general]
# settings that are not tied to the specific model used

[bilstm-crf-ner]
# some model specific settings here

[bert-ner]
# some model specific settings here

not clear which is a better solution. The first one may end up generating a lot of config files. The second a single, but very long config file.

Look here for inspiration:

@JohnGiorgi JohnGiorgi self-assigned this Feb 28, 2019
@JohnGiorgi JohnGiorgi added the invalid This doesn't seem right label Feb 28, 2019
@JohnGiorgi JohnGiorgi added the enhancement New feature or request label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant