Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics class should behave more like Keras's default History Callback #149

Open
JohnGiorgi opened this issue Jul 8, 2019 · 0 comments
Open

Metrics class should behave more like Keras's default History Callback #149

JohnGiorgi opened this issue Jul 8, 2019 · 0 comments
Assignees
@JohnGiorgi
Labels
chore enhancement New feature or request invalid This doesn't seem right

Comments

@JohnGiorgi
Copy link
Contributor

The Metrics class is a bit of a mess. It should behave more like a Keras History callback, and should be the returned object from a call to saber.train().

This would make hyperparm tuning much easier. E.g. a simple script could be written to collect the average performance of some metric or loss from the Metrics object returned by saber.train(), and tune against it.
@JohnGiorgi JohnGiorgi added enhancement New feature or request invalid This doesn't seem right chore labels Jul 8, 2019
@JohnGiorgi JohnGiorgi self-assigned this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnGiorgi JohnGiorgi

Labels
chore enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohnGiorgi