Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting of training data should be model agnostic. #153

Open
JohnGiorgi opened this issue Jul 24, 2019 · 0 comments
Open

Splitting of training data should be model agnostic. #153

JohnGiorgi opened this issue Jul 24, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@JohnGiorgi
Copy link
Contributor

Currently, the splitting of training data (into a validation or cross-validation split(s)) happens in prepare_data_for_training() which is defined by each model

It should be moved from the models themselves to saber.Saber, i.e, it should be model agnostic.

@JohnGiorgi JohnGiorgi self-assigned this Jul 24, 2019
@JohnGiorgi JohnGiorgi added enhancement New feature or request invalid This doesn't seem right labels Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant