Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Chore: Add Toll Plazas to Acceptance Criteria Summaries #136

Open
2 of 3 tasks
DavidOry opened this issue Feb 14, 2024 · 0 comments
Open
2 of 3 tasks

🧹 Chore: Add Toll Plazas to Acceptance Criteria Summaries #136

DavidOry opened this issue Feb 14, 2024 · 0 comments
Assignees
Labels
chore overhead: doesn't add additional functionality, change performance, or refactor code

Comments

@DavidOry
Copy link
Collaborator

DavidOry commented Feb 14, 2024

In addition to summarizing the performance of the Acceptance Criteria, the Acceptance Criteria summaries provide a host of useful diagnostics. On the roadway side, the network is trimmed to make the size manageable by excluding all the facility types lower than 6, which excludes all local roads. One drawback of this is that the toll plazas are coded as facility type 7, to represent the queueing that occurs in congestion conditions. The QA/QC maps therefore do not show the plazas, which means we can not readily examine the toll plaza delay when viewing the network diagnostics. We can readily fix this by adding in the facility type 7 links that include a non-zero @tollbooth value.

Progress:

  • Sufficiently defined
  • Approach decided
  • Implemented

Considerations

This is the relevant piece of code:

s_trim_df = s_df[
s_df["ft"] <= self.MAX_FACILITY_TYPE_FOR_ROADWAY_COMPARISONS
].copy()

We can change to:

s_trim_df = s_df[(s_df["ft"] <= self.MAX_FACILITY_TYPE_FOR_ROADWAY_COMPARISONS) & (s_df["@tollboth"] == 0)].copy()

@AshishKuls: can you please make this change and update the version-01 Tableau summaries?

fyi @FlaviaTsang, @lmz, @gregerhardt

@DavidOry DavidOry added the chore overhead: doesn't add additional functionality, change performance, or refactor code label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore overhead: doesn't add additional functionality, change performance, or refactor code
Projects
Status: Todo
Development

No branches or pull requests

2 participants