Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user select the type of shell in shell filters #146

Open
Nusiq opened this issue Mar 6, 2022 · 2 comments
Open

Let user select the type of shell in shell filters #146

Nusiq opened this issue Mar 6, 2022 · 2 comments
Labels
feature New feature or request needs discussion

Comments

@Nusiq
Copy link
Member

Nusiq commented Mar 6, 2022

Currently it goes through the list {"powershell", "-command"}, {"cmd", "/k"}, {"bash", "-c"}, {"sh", "-c"}} and picks whichever is available first (so... always powershell on windows I guess).

@stirante
Copy link
Member

stirante commented Mar 7, 2022

Original cmd is being slowly phased out on windows iirc. Also I intentionally did not add a way to specify shell, because that would make it platform dependant.
One way to fix it would be to make shell filter accept unix script and windows script separately and choosing the shell separately as well

@Nusiq
Copy link
Member Author

Nusiq commented Mar 7, 2022

Shell commands are different in different shells so it's platform dependent anyways.

@SirLich SirLich added feature New feature or request needs discussion labels Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request needs discussion
Projects
None yet
Development

No branches or pull requests

3 participants