Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move server_name/service_name in RegisterRosAction/RegisterRosService #14

Open
panwauu opened this issue May 20, 2022 · 2 comments
Open

Comments

@panwauu
Copy link

panwauu commented May 20, 2022

I think that the server_name and service_name bloats the behavior-tree and additionally add "ros logic" into the behavior-tree.
It would be more elegant in my opinion to add the server_name/service_name when registering the node.
I tried to make the change myself, but the nodes are always failing.
Can somebody help me with?

Thanks

@facontidavide
Copy link
Collaborator

I understand the fact that it add bloat, but I would rather keep two implementation (name as port or passed to the constructor).

To understand why your modified version don't work, you need to share a runnable example with me.

@panwauu
Copy link
Author

panwauu commented May 20, 2022

Good point to keep both options!
I started PR #16 to show my version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants