Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to etc1_global_selector_codebook from transcoder wiki page #367

Closed
SafariMonkey opened this issue Dec 6, 2023 · 2 comments

Comments

@SafariMonkey
Copy link

I was trying to use the transcoder, and I was using the wiki found here:

https://github.com/BinomialLLC/basis_universal/wiki/How-to-Use-and-Configure-the-Transcoder

which has the following section:

Also, ideally once at startup, you need to create a single instance of the basist::etc1_global_selector_codebook class, like this:

basist::etc1_global_selector_codebook sel_codebook(basist::g_global_selector_cb_size, basist::g_global_selector_cb);

This did not compile, so I looked at the repo history and saw that etc1_global_selector_codebook was removed almost everywhere in commit deeb5ac.

..., removing global selector palette code (it was unused/dead code), ...

I would suggest removing the line from the wiki, as while it's easy on first compile to tell that it doesn't work, figuring out whether one must do something else instead can take some time. (My interpretation after reading through that commit is that there is no replacement operation necessary.)

@tim-rex
Copy link

tim-rex commented Dec 7, 2023

Duplicate of #365, though this issue is probably more descriptive

@SafariMonkey
Copy link
Author

@tim-rex Oh, thanks! I searched for "etc1_global_selector_codebook" and when I got no results I assumed there wasn't an issue yet. This has a "mentioned" link there now, so if there is value in the description it won't be lost. I'll close this.

@SafariMonkey SafariMonkey closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants