Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when calling push-sum optimizer #112

Open
yangxuanfei opened this issue Jun 15, 2022 · 3 comments
Open

Error when calling push-sum optimizer #112

yangxuanfei opened this issue Jun 15, 2022 · 3 comments
Assignees

Comments

@yangxuanfei
Copy link

Note that the bottom layer has the definition of DistributedPushSumOptimizer, why call this error:
AttributeErron: module "bluefog.torch’’has no attribute 'DistributedPushSumOntimizer‘

@BichengYing
Copy link
Collaborator

Hi yangxuanfei,

It is might because of the typo? DistributedPushSumOntimizer, note you wrote Ontimizer instead of Optimizer?

The definition of this in here:
https://github.com/Bluefog-Lib/bluefog/blob/master/bluefog/torch/optimizers.py#L1180

If it is note the typo, could check the versions?

Thanks

@BichengYing BichengYing self-assigned this Jun 17, 2022
@yangxuanfei
Copy link
Author

Thanks for the reply, but I checked and it wasn't a typo. Are you referring to the version problem of bluefog? We are using version 0.3.0, is this a problem?

@BichengYing
Copy link
Collaborator

Oh, we didn't expose this optimizer. See the source code here https://github.com/Bluefog-Lib/bluefog/blob/master/bluefog/torch/__init__.py#L21
Because we are not satisfied the current implementation and the performance doesn't seem very good.

However, if you really want to use it, you can try this

from bluefog.torch.optimizers import DistributedPushSumOptimizer

I will encourage you to improve the original source code if you have any idea. Code is here

class _DistributedPushSumOptimizer(torch.optim.Optimizer):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants