Missing boundary check

[theolivenbaum]

Hi, just to let you know, it seems like there is a missing boundary check on this line too:

CsIcnsReader/BrokenEvent.Icns/BrokenEvent.LibIcns/LibIcns/Rle24Compression.cs

Line 36 in d49e887

result[band + 4 * (resultPos++)] = data[dataPos + 1];

Changing the code to this fixes the issue:

for (int i = 0; i < count; i++)
{
    var idx = band + 4 * (resultPos++);
    if (idx < result.Length)
    result[idx] = data[dataPos + 1];
}

[preseverence]

Didn't encounter cases where it breaks, but anyway that branch must be stabilized too. Thx.

[theolivenbaum]

Strange, we were hitting that often on macOS Monterey, most icons from the macOS preferences were throwing there

[preseverence]

Is everything ok now, with the recent commit? Also you can send me that icons somehow for experiments.
Actually, I don't work much with icns. So the issue was discovered just recently.