Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when setting shake invocation #16

Open
schukin opened this issue Feb 22, 2019 · 4 comments
Open

Crash when setting shake invocation #16

schukin opened this issue Feb 22, 2019 · 4 comments

Comments

@schukin
Copy link
Contributor

schukin commented Feb 22, 2019

http://crashes.to/s/c4ec0bcd1b7

Reported by @oferRounds. This appears to be caused by React Native calling Buglife setters off the main thread, which Buglife Android isn't currently designed to support. Working on a fix for this currently.

@danhd123
Copy link
Contributor

In particular, it's caused by a race condition in setting the invocation method from multiple threads at once or in quick succession (only from different threads; it's fine to call it it repeatedly on the same thread). For now, just don't do that.

@oferRounds
Copy link
Contributor

@schukin any chance someone from the team could try to fix it? Getting more of this

@danhd123
Copy link
Contributor

danhd123 commented Mar 4, 2019

Until there is a fix for this, please refrain from setting the invocation method more than once within any sort of short timespan. React Native Android does not have the same support for choosing a thread/queue to run calls into native packages on, which React Native iOS does. A shim may be required at the Module layer to force calls onto, eg. the main thread (or something serial with a Looper, anyway), but we don't have the engineering resources to put to this right now.

@oferRounds
Copy link
Contributor

Got you. I understand, no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants