Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Tests Fail due to Small Tolerances on Almost Equal Comparisons #32

Open
swainn opened this issue May 24, 2019 · 4 comments
Open

Many Tests Fail due to Small Tolerances on Almost Equal Comparisons #32

swainn opened this issue May 24, 2019 · 4 comments
Assignees

Comments

@swainn
Copy link
Collaborator

swainn commented May 24, 2019

I've marked many of the tests with xfail (expected fail) b/c most of them use almost equal comparisons on files with very small tolerances. As a result, the tests fail on many systems due to the natural variance from system to system.

When marked as xfail, these tests will still run, but won't cause the test suite to fail when they fail.

@swainn
Copy link
Collaborator Author

swainn commented May 24, 2019

Oh and at least two of the xfail tests are failing b/c they are using deprecated xarray calls.

@snowman2
Copy link
Member

If I remember correctly, my logic here was to get the tests passing with the strictest tolerance possible. With all of the changes to GDAL and PROJ since I touched them, I would recommend regenerating the test files and manually inspecting them to see if they work.

@snowman2
Copy link
Member

Also, the tolerance is arbitrary. Maybe 2-3 decimal places would be better.

@swainn
Copy link
Collaborator Author

swainn commented May 28, 2019

@snowman2 I agree, but I’m not familiar enough with the code to regenerate the test files and know if they are valid. I recommend either you do it or someone at ERDC that has an interest in those parts of the library. The core ORM functionality is working and test are passing, which is all I need at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants