Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully when chericat cannot attach to a pid #4

Open
InterestedInTechAndCake opened this issue Oct 12, 2023 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@InterestedInTechAndCake
Copy link
Collaborator

The pid could be invalid or it doesn't exist, or chericat (the user who runs it) does not have enough privilege to attach the target process. When this happens, currently chericat would fail an assertion and abort which looks like a crash:

$ bin/chericat -p 12355 -v
Assertion failed: (freep != NULL), function scan_mem, file ./src/mem_scan.c, line 63.
Abort trap (core dumped)

This is way too dramatic, instead chericat should simply exit with a useful message to tell the user why it cannot run.

@InterestedInTechAndCake InterestedInTechAndCake added the enhancement New feature or request label Oct 12, 2023
@InterestedInTechAndCake
Copy link
Collaborator Author

Fix is provided by #12

@InterestedInTechAndCake
Copy link
Collaborator Author

Initial changes merged, there are outstanding minor improvements suggested on #12, hence leaving this issue open until they are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants