Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer source code appears in search results #34

Open
SeanDS opened this issue Jan 10, 2022 · 1 comment
Open

Viewer source code appears in search results #34

SeanDS opened this issue Jan 10, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@SeanDS
Copy link

SeanDS commented Jan 10, 2022

It seems the JavaScript source code for the 3D viewer shows up in Sphinx's compiled search index. I can see this by searching for var parent (which is part of the 3D viewer's script) on the CadQuery website:

image

which actually looks like this:

image

with no var parent visible.

Is there a way to avoid this ugly side-effect?
@Peque Peque added enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Jan 14, 2022
@Peque
Copy link
Collaborator

Peque commented Jan 14, 2022

@SeanDS Thanks for reporting! 😊

Maybe there is a way. I unfortunately do not currently have time to look at this, but would happily accept a pull request! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Peque @SeanDS