Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the manifest serialization and deserialization #598

Open
3 of 4 tasks
goldmedal opened this issue Jun 6, 2024 · 0 comments
Open
3 of 4 tasks

Enhance the manifest serialization and deserialization #598

goldmedal opened this issue Jun 6, 2024 · 0 comments
Labels
enhancement New feature or request modeling-rs

Comments

@goldmedal
Copy link
Contributor

goldmedal commented Jun 6, 2024

Description

Currently, the manifest in Rust side is a simple DTO. We should add more checking rules when deserialization. For example, a model can accept refSql, tableReference or baseObject. However, we didn't check it in Rust side.

Basically, we should follow the original behavior in java side.
https://github.com/Canner/wren-engine/tree/main/wren-base/src/main/java/io/wren/base/dto

Maybe we can also validate the generated JSON by
https://github.com/Canner/WrenAI/blob/main/wren-mdl/mdl.schema.json

Collect the related issues

@goldmedal goldmedal added enhancement New feature or request modeling-rs labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modeling-rs
Projects
None yet
Development

No branches or pull requests

1 participant