Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot be "null" error should be handled client side #26

Open
ftrotter opened this issue Feb 15, 2018 · 0 comments
Open

Cannot be "null" error should be handled client side #26

ftrotter opened this issue Feb 15, 2018 · 0 comments
Assignees

Comments

@ftrotter
Copy link
Contributor

It is super frustrating to click "save" and then be told after posting the data "something_id cannot be null". Then clicking the back button and every select2 box has been forgotten...

There are two fixes for this, and we should do both of them.

First, when a something_id cannot be null, then client side checking should ensure that that form cannot be submitted without choosing something...

Second, when there is a server side rejection of data saving, and a back button needs to be pressed (this will happen after all, with custom data-saving code) the select2 values chosen should be "remembered" after the back button is clicked.

This is advanced functionality, but it would be lovely if this just worked.

-FT

@ftrotter ftrotter added the 1.0 requirement Things we need in initial release label Sep 9, 2019
@ftrotter ftrotter changed the title Cannot be "null" error is super annoying Cannot be "null" error should be handled client side Oct 30, 2019
@ftrotter ftrotter removed the 1.0 requirement Things we need in initial release label Oct 30, 2019
@kchapple kchapple self-assigned this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants