Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raster overlays don't work with non-indexed triangles, or with triangle fans or strips #918

Open
kring opened this issue Jun 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kring
Copy link
Member

kring commented Jun 28, 2024

The top of upsamplePrimitiveForRasterOverlays has this:

  if (primitive.mode != MeshPrimitive::Mode::TRIANGLES ||
      primitive.indices < 0 ||
      primitive.indices >= static_cast<int>(parentModel.accessors.size())) {
    // Not indexed triangles, so we don't know how to divide this primitive
    // (yet). So remove it.
    return false;
  }

Fortunately, indexed triangle lists are the most common by far, so as far as I'm aware no one has ever actually complained about this. But still, we should round out this functionality.

@csciguy8
Copy link
Contributor

PR #777 has lots of code for dealing with non-indexed tris, fans, and strips. Could be helpful as reference.

@j9liu j9liu added the bug Something isn't working label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants