Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ellipsoid parameter #953

Open
lilleyse opened this issue Sep 30, 2024 · 2 comments
Open

Missing ellipsoid parameter #953

lilleyse opened this issue Sep 30, 2024 · 2 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Sep 30, 2024

An ellipsoid should get passed to BoundingRegion here:

CesiumGeospatial::BoundingRegion(
globeRectangle,
details.boundingRegion.getMinimumHeight(),
details.boundingRegion.getMaximumHeight()),

Caught while compiling with CESIUM_DISABLE_DEFAULT_ELLIPSOID

@azrogers
Copy link
Contributor

azrogers commented Oct 1, 2024

Good catch! I'll make a PR to fix this. Perhaps we should be building for CI with CESIUM_DISABLE_DEFAULT_ELLIPSOID to catch bugs like this?

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 1, 2024

Perhaps we should be building for CI with CESIUM_DISABLE_DEFAULT_ELLIPSOID to catch bugs like this?

I think that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants