From 85d6b39039d317c6b6c1a3f63cb591377784f90e Mon Sep 17 00:00:00 2001 From: Ashley Rogers Date: Thu, 10 Oct 2024 15:58:36 -0400 Subject: [PATCH] Clean up CesiumTextureUtility --- Source/CesiumRuntime/Private/CesiumTextureUtility.cpp | 1 - Source/CesiumRuntime/Private/CesiumTextureUtility.h | 8 +------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/Source/CesiumRuntime/Private/CesiumTextureUtility.cpp b/Source/CesiumRuntime/Private/CesiumTextureUtility.cpp index 603b6bde9..3e2ccb908 100644 --- a/Source/CesiumRuntime/Private/CesiumTextureUtility.cpp +++ b/Source/CesiumRuntime/Private/CesiumTextureUtility.cpp @@ -362,7 +362,6 @@ bool getUseMipmapsIfAvailableFromSampler(const CesiumGltf::Sampler& sampler) { case CesiumGltf::Sampler::MinFilter::NEAREST_MIPMAP_LINEAR: case CesiumGltf::Sampler::MinFilter::NEAREST_MIPMAP_NEAREST: return true; - break; default: // LINEAR and NEAREST return false; } diff --git a/Source/CesiumRuntime/Private/CesiumTextureUtility.h b/Source/CesiumRuntime/Private/CesiumTextureUtility.h index 3c1b9d8e5..a6989684b 100644 --- a/Source/CesiumRuntime/Private/CesiumTextureUtility.h +++ b/Source/CesiumRuntime/Private/CesiumTextureUtility.h @@ -90,8 +90,6 @@ struct LoadedTextureResult { * associated Unreal texture. * @param sRGB True if the texture should be treated as sRGB; false if it should * be treated as linear. - * @param textureResources Unreal RHI texture resources that have already been - * created for this model. This array must have the same size as `model`'s * {@link CesiumGltf::Model::images}, and all pointers must be initialized to * nullptr before the first call to `loadTextureFromModelAnyThreadPart` during * the glTF load process. @@ -112,10 +110,6 @@ TUniquePtr loadTextureFromModelAnyThreadPart( * @param sampler The sampler settings to use with the texture. * @param sRGB True if the texture should be treated as sRGB; false if it should * be treated as linear. - * @param pExistingImageResource An existing RHI texture resource that has been - * created for this image, or nullptr if one hasn't been created yet. When this - * parameter is not nullptr, the provided image's `pixelData` is not required - * and can be empty. */ TUniquePtr loadTextureFromImageAndSamplerAnyThreadPart( CesiumGltf::ImageAsset& image, @@ -129,7 +123,7 @@ TUniquePtr loadTextureFromImageAndSamplerAnyThreadPart( * for {@link ExtensionImageAssetUnreal::getFuture} to resolve. This method * should be called in a background thread. * - * @param imageCesium The image. + * @param image The image. * @param addressX The X addressing mode. * @param addressY The Y addressing mode. * @param filter The sampler filtering to use for this texture.