From 2b9969415295e27512784fa7aebc1ca63b1b3f8b Mon Sep 17 00:00:00 2001 From: aristosvo <8375124+aristosvo@users.noreply.github.com> Date: Mon, 5 Feb 2024 16:57:57 +0100 Subject: [PATCH 1/4] fix: improve query name for security group without description --- .../aws/security_group_without_description/metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/assets/queries/terraform/aws/security_group_without_description/metadata.json b/assets/queries/terraform/aws/security_group_without_description/metadata.json index 0b4c8b1d3c1..3dbb8a11e6b 100644 --- a/assets/queries/terraform/aws/security_group_without_description/metadata.json +++ b/assets/queries/terraform/aws/security_group_without_description/metadata.json @@ -1,6 +1,6 @@ { "id": "cb3f5ed6-0d18-40de-a93d-b3538db31e8c", - "queryName": "Security Group Rule Without Description", + "queryName": "Security Group Without Description", "severity": "INFO", "category": "Best Practices", "descriptionText": "It's considered a best practice for AWS Security Group to have a description", @@ -9,4 +9,4 @@ "descriptionID": "bc535d27", "cloudProvider": "aws", "cwe": "" -} \ No newline at end of file +} From b04ba8239d91a0dbaad47e7e186dcb239e728aed Mon Sep 17 00:00:00 2001 From: aristosvo <8375124+aristosvo@users.noreply.github.com> Date: Wed, 9 Oct 2024 13:32:36 +0200 Subject: [PATCH 2/4] fix: remove newline From 2daa0aac194c1322fb80e4cd5c70a1974bc01f59 Mon Sep 17 00:00:00 2001 From: aristosvo <8375124+aristosvo@users.noreply.github.com> Date: Wed, 9 Oct 2024 13:33:52 +0200 Subject: [PATCH 3/4] fix: next try newline From 9d02c3b40ecaf9009564a154400a5af839f4a150 Mon Sep 17 00:00:00 2001 From: aristosvo <8375124+aristosvo@users.noreply.github.com> Date: Wed, 9 Oct 2024 21:56:03 +0200 Subject: [PATCH 4/4] fix: update test --- .../test/positive_expected_result.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/queries/terraform/aws/security_group_without_description/test/positive_expected_result.json b/assets/queries/terraform/aws/security_group_without_description/test/positive_expected_result.json index be1032186a6..359317244ee 100644 --- a/assets/queries/terraform/aws/security_group_without_description/test/positive_expected_result.json +++ b/assets/queries/terraform/aws/security_group_without_description/test/positive_expected_result.json @@ -1,6 +1,6 @@ [ { - "queryName": "Security Group Rule Without Description", + "queryName": "Security Group Without Description", "severity": "INFO", "line": 1, "filename": "positive1.tf"