Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCPInstance start function is missing #308

Open
Jegeva opened this issue Sep 9, 2022 · 7 comments
Open

GCPInstance start function is missing #308

Jegeva opened this issue Sep 9, 2022 · 7 comments

Comments

@Jegeva
Copy link

Jegeva commented Sep 9, 2022

the right code is already implemented i nreboot but there should be a start function implemented

@nuwang
Copy link
Contributor

nuwang commented Sep 9, 2022

A start function would need to be added to the cloudbridge VM Instance interface here and implemented for all providers.

@Jegeva
Copy link
Author

Jegeva commented Sep 9, 2022

The documentation states that there should be one :
http://cloudbridge.cloudve.org/en/latest/api_docs/cloud/resources.html#cloudbridge.interfaces.resources.Instance,

the abstract is here already :

It's just that the implementation is missing in GCP (maybe in others, i didn't check)

@theshashankpal
Copy link

Hi @Jegeva,
This issue seems to be a good initiation of my journey towards contribution to FOSS projects.
Can you please assign this to me?

@nuwang
Copy link
Contributor

nuwang commented Sep 10, 2022

Looks like the start and stop functions have been implemented, but for aws only. The following would need to be done.
a. Implement start/stop functions for the remaining providers
b. Make sure this test passes for all providers, not just aws:

def test_instance_start_stop_methods(self):

We are happy to assign this to you @theshashankpal. Feel free to write back with any questions and thanks for volunteering to help.

@theshashankpal
Copy link

Thank You!

@theshashankpal
Copy link

theshashankpal commented Oct 30, 2022 via email

@nuwang
Copy link
Contributor

nuwang commented Oct 30, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants