Skip to content

TypeScript definition bugs/tweaks. #20

Description

@niemyjski

I'm leaving this feedback here as you guys submitted a typescript def.

I noticed a typescript def bug when I tried doing the following:

new ko.DirtyFlag([observablebool, observablenumber]);

I ended up having to do this to get it to compile:
new ko.DirtyFlag([observablebool, observablenumber]);

Also, You have commands defined as KoliteCommand but the interface for Dirty is DirtyFlag, I was thinking it would be KoliteDirtyFlag.

Also if you specify a property type for DirtyFlag, you can't create a new instance of it in your constructor. It really complains about it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions