Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Buider: ScriptUtil.closeDisplay missing #3036

Closed
pavel-ch opened this issue Jun 6, 2024 · 2 comments
Closed

Display Buider: ScriptUtil.closeDisplay missing #3036

pavel-ch opened this issue Jun 6, 2024 · 2 comments

Comments

@pavel-ch
Copy link
Collaborator

pavel-ch commented Jun 6, 2024

After update to latest code, I am missing the Display Builder: ScriptUtil.closeDisplay method. This was wiped out with "CSSTUDIO-1987 New "Unsaved Changes" confirmation dialog #2758" in "CSSTUDIO-1987 Remove unused code. ffe810a" commit from @abrahamwolk on 27.7.2023.
However, the code was not unused! We use it in our applications.
The script API should be as stable as possible, as no one knows whether it was used in user applications.
@abrahamwolk could you revert this simple change (commit), or can I do it? Are there any complications with doing that?
Thank you!

@abrahamwolk
Copy link
Collaborator

@pavel-ch My apologies, that commit was based on unsound reasoning: the code appeared unused in my IDE since no Java function calls it, but, as you point out, that doesn't mean that no script is using it!

You are right that the script API should be as stable as possible.

I have created a PR to revert this change: #3037. I don't believe there should be any complications from reverting this change.

@abrahamwolk
Copy link
Collaborator

@pavel-ch The fix has been merged now.

@shroffk shroffk closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants