You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After update to latest code, I am missing the Display Builder: ScriptUtil.closeDisplay method. This was wiped out with "CSSTUDIO-1987 New "Unsaved Changes" confirmation dialog #2758" in "CSSTUDIO-1987 Remove unused code. ffe810a" commit from @abrahamwolk on 27.7.2023.
However, the code was not unused! We use it in our applications.
The script API should be as stable as possible, as no one knows whether it was used in user applications. @abrahamwolk could you revert this simple change (commit), or can I do it? Are there any complications with doing that?
Thank you!
The text was updated successfully, but these errors were encountered:
@pavel-ch My apologies, that commit was based on unsound reasoning: the code appeared unused in my IDE since no Java function calls it, but, as you point out, that doesn't mean that no script is using it!
You are right that the script API should be as stable as possible.
I have created a PR to revert this change: #3037. I don't believe there should be any complications from reverting this change.
After update to latest code, I am missing the Display Builder: ScriptUtil.closeDisplay method. This was wiped out with "CSSTUDIO-1987 New "Unsaved Changes" confirmation dialog #2758" in "CSSTUDIO-1987 Remove unused code. ffe810a" commit from @abrahamwolk on 27.7.2023.
However, the code was not unused! We use it in our applications.
The script API should be as stable as possible, as no one knows whether it was used in user applications.
@abrahamwolk could you revert this simple change (commit), or can I do it? Are there any complications with doing that?
Thank you!
The text was updated successfully, but these errors were encountered: