Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is still compressed when maxWidth is null #1071

Open
vwmberry95 opened this issue Apr 25, 2022 · 1 comment
Open

Text is still compressed when maxWidth is null #1071

vwmberry95 opened this issue Apr 25, 2022 · 1 comment

Comments

@vwmberry95
Copy link

Issue Details

  • Version used (Ex; 1.0):

1.0.0

  • Describe whats happening (Include any relevant console errors, a Gist is preferred for longer errors):

According to the documentation:

"The maximum width to draw the text. If maxWidth is specified (not null), the text will be condensed or shrunk to make it fit in this width." However, the text still gets condensed after large amounts of text. It appears to get capped when drawing the text by setting 0xFFFF: https://createjs.com/docs/easeljs/files/easeljs_display_Text.js.html#l401.

  • OS & Browser version (Please be specific) (Ex; Windows 10 Home, Chrome 62.0.3202.94):

Android 8/9/10 Chrome 85.0.4183.81
Windows 10/11 Chrome 100.0.4896.127 (latest)

  • Do you know of any workarounds?

Set maxWidth = Number.MAX_VALUE

  • Provide any extra details that will help us fix your issue. Including a link to a CodePen.io or JSFiddle.net example that shows the issue in isolation will greatly increase the chance of getting a quick response.

http://jsfiddle.net/ft2v1Lem/

@danzen
Copy link
Contributor

danzen commented Sep 12, 2022

Hi @vwmberry95 - 0xFFFF is 65,535... what are you doing? If you shrink text that big to a mobile screen you will not be able to read it. And... oh no, we did not even realize there was a maxWidth property that worked this way and ended up building it in to ZIM Label - doh! So, ZIM version might work as you expect. https://zimjs.com and see https://zimjs.com/docs.html?item=Label with the parameter being labelWidth (also see labelHeight)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants