Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All organization /resources URLs are returning null #713

Open
mparsons-ce opened this issue Jun 27, 2024 · 4 comments
Open

All organization /resources URLs are returning null #713

mparsons-ce opened this issue Jun 27, 2024 · 4 comments

Comments

@mparsons-ce
Copy link
Contributor

The following URL returns null:
https://credentialengineregistry.org/resources/ce-0abf92da-5536-4670-bb47-636a3f330d7c

Yet, these return data:
https://credentialengineregistry.org/graph/ce-0abf92da-5536-4670-bb47-636a3f330d7c
https://credentialengineregistry.org/envelopes/ce-0abf92da-5536-4670-bb47-636a3f330d7c

Quick testing suggests that this is only an issue for organizations

@excelsior
Copy link
Collaborator

@mparsons-ce Some of the organization resources were not extracted, although the envelopes themselves were published successfully. However, instead of 404s, nulls were returned.

I re-processed the envelopes, now the /resources endpoint returns correct data.

Why some resources were not extracted is an open question.

@jeannekitchens
Copy link

jeannekitchens commented Aug 19, 2024

@excelsior @mparsons-ce can this be closed?

@jeannekitchens
Copy link

@excelsior @edgarf what is the follow up on this?

@excelsior
Copy link
Collaborator

@jeannekitchens The data issue has been fixed. I also did some improvements towards the publishing flow to reduce the chances of it happening again.

I'm working on adding some data consistency checks, as well as fixing the API to respond with a correct status instead of a null response. The latter is a bug, too, so let's keep this issue open until it resolved.

excelsior added a commit to learningtapestry/CredentialRegistry that referenced this issue Oct 22, 2024
excelsior added a commit to learningtapestry/CredentialRegistry that referenced this issue Oct 23, 2024
excelsior added a commit that referenced this issue Oct 23, 2024
…und-response

(#713) Improve fetching envelope resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants