Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

had_12_paley is still used instead of the had_12 added in #5 #8

Open
swolchok opened this issue Jul 25, 2024 · 2 comments
Open

had_12_paley is still used instead of the had_12 added in #5 #8

swolchok opened this issue Jul 25, 2024 · 2 comments

Comments

@swolchok
Copy link

Looks like the code generator just needs a one-line patch to replace had_12_paley by had_12, here: https://github.com/Dao-AILab/fast-hadamard-transform/blob/master/csrc/code_gen.py#L181

had_12 appears to match what QuaRot uses: https://github.com/spcl/QuaRot/blob/main/fake_quant/hadamard_utils.py#L152 (haven't exhaustively inspected it, but the first and second column match had_12 and not had_12_paley)

@swolchok
Copy link
Author

Looks like @hychiang-git may have just overlooked this in #5?

@hychiang-git
Copy link
Contributor

I opted to use had_12_paley to follow the original implementation. I added had_12 in the PR for the people who like to use had_12. It is configurable, but you need to recompile the package. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants