Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a _default in manifest #2418

Open
cbeauchesne opened this issue May 2, 2024 · 1 comment
Open

Adds a _default in manifest #2418

cbeauchesne opened this issue May 2, 2024 · 1 comment

Comments

@cbeauchesne
Copy link
Collaborator

cbeauchesne commented May 2, 2024

Sometimes, an entire file is activated at the same version :

test.py
     test_classA: v2.3.4
     test_classB: v2.3.4
     test_classC: v2.3.4

And if it's a map of variant, it become a little bit verbose.

The idea is to support a _default value :

test.py
     _default: v2.3.4

-> all classes in test.py will be activated at v2.3.4

The _default value is used if, and only if nothing is specified for a class. If something is specified, the _default value is ignored.

The keywork _default is used, meaning we wont be able to name a file _default.

Examples

test.py
     _default: v2.3.4
     test_classC: v4.0

-> all classes in test.py will be activated at v2.3.4, except test_classC who will be activated at v4.0

test.py
     _default: v2.3.4
     test_classC:
        nextjs: missing_feature

-> all classes in test.py will be activated at v2.3.4, except test_classC who will be flagged as missing for nextjs, and activated for all others (activation by default)

test.py
     _default:
        '*': v2.3.4
        'poc': bug
     test_classC: v4.0

-> all classes in test.py will be flagged as bug for poc, and activated at v2.3.4 for other variants, except test_classC who will activated at v4.0 for all variants

@cbeauchesne
Copy link
Collaborator Author

Actually, '*' may be a better choice :

  • No possible file name collision
  • Already used for variant defaulting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant