Hi, thank you for releasing the PerturbDiff implementation. I noticed a possible mismatch between the DDIM sampling configuration and the training diffusion schedule.
The model is configured with a 1000-step diffusion process:
However, the default sampling configuration uses:
In [resolve_sampling_runner](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/src/apps/sampling/sampling_generation_helpers.py#L23-L34), this value is passed directly to ddim_sample_loop as start_time. The DDIM loop then:
- Initializes the state from standard Gaussian noise:
img = noise if noise is not None else th.randn(*shape, device=device)
- Constructs consecutive timestep indices:
indices = list(range(start_time))[::-1]
Therefore, with the default configuration, sampling starts from pure Gaussian noise at timestep 99 and performs 100 consecutive updates:
99 -> 98 -> ... -> 1 -> 0
This behavior is implemented in [ddim_sample_loop_progressive](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/src/models/diffusion/diffusion_sampling.py#L559-L590). Each DDIM update also uses alphas_cumprod_prev[t], so it specifically transitions from timestep t to the adjacent timestep t-1, rather than between respaced timesteps:
My concern is that, under the default 1000-step linear schedule, timestep 99 is not close to the terminal Gaussian distribution. The configured beta schedule gives approximately:
alpha_bar[99] = 0.897
sqrt(alpha_bar[99]) = 0.947
sqrt(1 - alpha_bar[99]) = 0.321
Therefore, the forward-process state at timestep 99 is approximately:
x_99 = 0.947 * x_0 + 0.321 * noise
In other words, the training distribution at timestep 99 still contains a strong contribution from the clean sample. The sampler instead initializes:
If the intended goal is accelerated DDIM sampling with 100 model evaluations, I would expect the sampler to select approximately 100 respaced timesteps spanning the full training horizon from 999 to 0, and to calculate each update using the previous selected timestep. The current implementation instead appears to treat start_time as both the desired number of sampling steps and the actual starting diffusion timestep.
Could you please explain the rationale for initializing pure Gaussian noise at timestep 99? Is this behavior intentional, or should the 100-step DDIM sampler use a respaced timestep sequence covering the full 1000-step training schedule?
Thank you for your time and clarification.
Hi, thank you for releasing the PerturbDiff implementation. I noticed a possible mismatch between the DDIM sampling configuration and the training diffusion schedule.
The model is configured with a 1000-step diffusion process:
[configs/model/base.yaml](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/configs/model/base.yaml#L34-L38):steps: 1000However, the default sampling configuration uses:
[configs/rawdata_diffusion_sampling.yaml](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/configs/rawdata_diffusion_sampling.yaml#L38-L42):start_time: 100In
[resolve_sampling_runner](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/src/apps/sampling/sampling_generation_helpers.py#L23-L34), this value is passed directly toddim_sample_loopasstart_time. The DDIM loop then:Therefore, with the default configuration, sampling starts from pure Gaussian noise at timestep 99 and performs 100 consecutive updates:
This behavior is implemented in
[ddim_sample_loop_progressive](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/src/models/diffusion/diffusion_sampling.py#L559-L590). Each DDIM update also usesalphas_cumprod_prev[t], so it specifically transitions from timesteptto the adjacent timestept-1, rather than between respaced timesteps:[diffusion_sampling.py](https://github.com/DeepGraphLearning/PerturbDiff/blob/main/src/models/diffusion/diffusion_sampling.py#L263-L270)My concern is that, under the default 1000-step linear schedule, timestep 99 is not close to the terminal Gaussian distribution. The configured beta schedule gives approximately:
Therefore, the forward-process state at timestep 99 is approximately:
In other words, the training distribution at timestep 99 still contains a strong contribution from the clean sample. The sampler instead initializes:
If the intended goal is accelerated DDIM sampling with 100 model evaluations, I would expect the sampler to select approximately 100 respaced timesteps spanning the full training horizon from 999 to 0, and to calculate each update using the previous selected timestep. The current implementation instead appears to treat
start_timeas both the desired number of sampling steps and the actual starting diffusion timestep.Could you please explain the rationale for initializing pure Gaussian noise at timestep 99? Is this behavior intentional, or should the 100-step DDIM sampler use a respaced timestep sequence covering the full 1000-step training schedule?
Thank you for your time and clarification.