Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate local state for layout #451

Open
blondejamtart opened this issue Jan 30, 2019 · 1 comment
Open

Investigate local state for layout #451

blondejamtart opened this issue Jan 30, 2019 · 1 comment
Labels

Comments

@blondejamtart
Copy link
Contributor

Currently, the layout attribute does not have a local state, and as such can only be updated by receiving an update from malcolm.
Adding a local state would allow for optimistic updates (i.e. deleting links) and also allow for users without write permissions (i.e. remote users) to move blocks on their local layout so they can actually see them

@blondejamtart
Copy link
Contributor Author

blondejamtart commented Feb 22, 2019

Whilst flowgraph attributes don't have a local state, the current/last viewed layout does have one. Modifications have been made to the autolayout code to allow for this to be run only on the local state, it just needs to check an appropriate flag (i.e. writeable). Similar modifications to the move block action are needed. Fully "locking" the layout should not be done any more, but deleting/adding blocks and links should remain disabled. (N.B. this investigation was done as part of #450; deleting links now optimistically updates the layout local state)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant